Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: Fix injected args in tool signature #25991

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Sep 3, 2024

  • Fix injected args in tool signature
  • Fix another unit test that was using the wrong namespace import in pydantic

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 1:37am

@eyurtsev eyurtsev force-pushed the eugene/add_injected_tool_test branch from 509ed89 to afc46d3 Compare September 4, 2024 01:37
@eyurtsev eyurtsev changed the title core[patch]: Fix injected tool core[patch]: Fix injected args in tool signature Sep 4, 2024
@eyurtsev eyurtsev marked this pull request as ready for review September 4, 2024 01:53
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 4, 2024
@eyurtsev
Copy link
Collaborator Author

eyurtsev commented Sep 4, 2024

Force merging as it's failing due to compatibilty tests using pydantic

@eyurtsev eyurtsev merged commit 5f98975 into v0.3rc Sep 4, 2024
25 of 31 checks passed
@eyurtsev eyurtsev deleted the eugene/add_injected_tool_test branch September 4, 2024 01:53
@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: core Related to langchain-core size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant