core[patch]: wrap mermaid node names w/ markdown in <p> tag #26235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:S
dosubot
bot
added
Ɑ: core
nfcampos
reviewed
Sep 10, 2024
| @@ -1040,7 +1040,7 @@ | |||
| PromptTemplate(PromptTemplate) | |||
| FakeListLLM(FakeListLLM) | |||
| Parallel_as_list_as_str_Input(Parallel<as_list,as_str>Input) | |||
| Parallel_as_list_as_str_Output([Parallel_as_list_as_str_Output]):::last | |||
| Parallel_as_list_as_str_Output([Parallel<as_list,as_str>Output]):::last | |||
There was a problem hiding this comment.
why is this one changing?
There was a problem hiding this comment.
cause we used to do use key as display name for the last node, and we apply _escape_node_label on the key, but now since we're passing value explicitly, it's no longer escaped (which i think is actually better)
nfcampos
approved these changes
Sep 10, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where
__start__and__end__node labels are being interpreted as markdown, as of the most recent Mermaid update