openai[patch] get output_type when using with_structured_output #26307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:nit
dosubot
bot
added
size:S
eyurtsev
approved these changes
Sep 11, 2024
dosubot
bot
added
the
lgtm
|
Would need to take a more careful look to see if that's the appropriate place to set the output_type... current code seems to ignore the possibility that the schema is a dict |
|
@baskaryan tagging you in case this is a quick fix for you |
Fix type checking errors by declaring that the schema is a Pydantic BaseModel at this point.
dosubot
bot
added
size:M
Sheepsta300
pushed a commit
to Sheepsta300/langchain
that referenced
this pull request
Oct 1, 2024
…gchain-ai#26307) - This allows pydantic to correctly resolve annotations necessary when using openai new param `json_schema` Resolves issue: langchain-ai#26250 --------- Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com> Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_schemaResolves issue: #26250