Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli[patch]: migrate langchain-cli to use grit for migrations #26427

Merged
merged 14 commits into from
Sep 13, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Sep 13, 2024

Description
Replaces the libCST integration with GritQL. This has a few advantages:

  • There's less code to maintain, as Grit handles the complexities of actually replacing imports and remapping correctly (notice the big red reduction).
  • Grit includes advanced features like --interactive to allow interactive review of changes.

Dependencies

  • Added gritQL

Twitter handle
https://x.com/morgantepell

Testing
Existing tests continue to run correctly for the cli_runner.

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:35pm

@eyurtsev
Copy link
Collaborator Author

Just resolved merge conflicts still need to incorporate into the code

@eyurtsev eyurtsev changed the title cli[patch]: WIP cli[patch]: migrate langchain-cli to use grit for migrations Sep 13, 2024
@eyurtsev eyurtsev marked this pull request as ready for review September 13, 2024 20:47
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 13, 2024
@eyurtsev eyurtsev merged commit 70eef0f into v0.3rc Sep 13, 2024
12 checks passed
@eyurtsev eyurtsev deleted the grit-sample-integration branch September 13, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants