Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[experimental]: Fix text splitter with gradient #26629

Merged

Conversation

tibor-reiss
Copy link
Contributor

Fixes #26221

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 18, 2024
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 11:34pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Sep 18, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems right. could you add a unit test that fails on current that this fixes?

@efriis efriis self-assigned this Sep 19, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@tibor-reiss
Copy link
Contributor Author

this seems right. could you add a unit test that fails on current that this fixes?

@efriis sure, test added

@efriis
Copy link
Member

efriis commented Sep 20, 2024

thanks!

@efriis efriis enabled auto-merge (squash) September 20, 2024 23:34
@efriis efriis merged commit a8b2413 into langchain-ai:master Sep 20, 2024
20 checks passed
sfc-gh-nmoiseyev pushed a commit to sfc-gh-nmoiseyev/langchain that referenced this pull request Sep 21, 2024
Fixes langchain-ai#26221

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
@tibor-reiss tibor-reiss deleted the fix-26221-text-splitter-with-gradient branch September 21, 2024 12:45
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
Fixes langchain-ai#26221

---------

Co-authored-by: Erick Friis <erick@langchain.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

If distances is empty in the 'gradient' option of semantic chunker it causes IndexError.
2 participants