Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use ruff.target-version instead #26634

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

efriis
Copy link
Member

@efriis efriis commented Sep 18, 2024

tested on one of the replacement cases and seems to work!
ScreenShot 2024-09-18 at 02 02 43PM

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:02pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 18, 2024
@efriis efriis enabled auto-merge (squash) September 18, 2024 21:03
@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Sep 18, 2024
@efriis
Copy link
Member Author

efriis commented Sep 18, 2024

cc @cbornet @eyurtsev

@efriis
Copy link
Member Author

efriis commented Sep 18, 2024

related to #26633 #26608

@efriis efriis merged commit 9909354 into master Sep 18, 2024
98 checks passed
@efriis efriis deleted the erick/core-use-ruff-target-version-instead branch September 18, 2024 21:06
@cbornet
Copy link
Collaborator

cbornet commented Sep 18, 2024

👀 too bad we can’t have all tools work correctly with the project section 🤷‍♂️

Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
tested on one of the replacement cases and seems to work! 
![ScreenShot 2024-09-18 at 02 02
43PM](https://github.com/user-attachments/assets/7170975a-2542-43ed-a203-d4126c6a2c81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants