Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add ruff rules for flake8-simplify (SIM) #26848

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 25, 2024

No description provided.

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 8:10pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Sep 25, 2024
@cbornet cbornet force-pushed the ruff-rules-sim branch 3 times, most recently from 8280967 to 7d980bb Compare September 25, 2024 15:38
@eyurtsev
Copy link
Collaborator

Will this be autoformatted by ruff as well?

@eyurtsev eyurtsev self-assigned this Sep 26, 2024
@cbornet
Copy link
Collaborator Author

cbornet commented Sep 26, 2024

I’d say 95% auto-fix, 5% manual.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 27, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) September 27, 2024 20:10
@eyurtsev eyurtsev merged commit 7809b31 into langchain-ai:master Sep 27, 2024
85 checks passed
@cbornet cbornet deleted the ruff-rules-sim branch September 27, 2024 21:12
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants