community: Update file_path type in JSONLoader.__init__() signature
#27535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
efriis
approved these changes
Oct 22, 2024
dosubot
bot
added
the
lgtm
ccurme
pushed a commit
that referenced
this pull request
Oct 22, 2024
…re (#27535) - **Description:** Change the type of the `file_path` argument from `str | pathlib.Path` to `str | os.PathLike`, since the latter is more widely used: https://stackoverflow.com/a/58541858 This is a very minor fix. I was just annoyed to see the red underline displayed by Pylance in VS Code: `reportArgumentType`.  The changes do not affect the behavior of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Change the type of the
file_pathargument fromstr | pathlib.Pathtostr | os.PathLike, since the latter is more widely used: https://stackoverflow.com/a/58541858This is a very minor fix. I was just annoyed to see the red underline displayed by Pylance in VS Code:
reportArgumentType.The changes do not affect the behavior of the code.