core[patch]: rm image loading #27797
Merged
+35
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
Ɑ: core
dosubot
bot
added
size:L
efriis
reviewed
Oct 31, 2024
efriis
approved these changes
Oct 31, 2024
dosubot
bot
added
the
lgtm
eyurtsev
reviewed
Oct 31, 2024
| return f"data:{mime_type};base64,{encoding}" | ||
| def __getattr__(name: str) -> Any: | ||
| if name in ("encode_image", "image_to_data_url"): | ||
| msg = f"'{name}' has been removed for security reasons." |
There was a problem hiding this comment.
This is very cryptic!
- why did we remove encode_image / image_to_data_url are those not fine if users just use them as a utility? (i also get that they're really light weight so maybe we don't need them.)
- The error message is cryptic. Could we provide at least one more detail? It's not clear why the utility functions themselves would be a security concern.
The main concern is that this going to break user code, so would be ideal to provide information. Including the version as of which this change was made
|
Is there any information why this was removed? As this breaks already working code in the 0.3 branch it would be nice to at least know why this is a security issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for v0.3.x branch