-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add Needle retriever and document loader integration #28157
Open
JANHMS
wants to merge
20
commits into
langchain-ai:master
Choose a base branch
from
JANHMS:Integration-Needle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+889
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
community
Related to langchain-community
Ɑ: doc loader
Related to document loader module (not documentation)
Ɑ: retriever
Related to retriever module
labels
Nov 16, 2024
JANHMS
changed the title
community: integration needle
community: add Needle retriever and document loader integration
Nov 16, 2024
JANHMS
force-pushed
the
Integration-Needle
branch
from
November 16, 2024 15:39
1f65a78
to
7280ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
Related to langchain-community
Ɑ: doc loader
Related to document loader module (not documentation)
Ɑ: retriever
Related to retriever module
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title: "community: add Needle retriever and document loader integration"
PR message: Delete this entire checklist and replace with
docs/docs/integrations/retrievers/needle.ipynb
docs/docs/integrations/document_loaders/needle.ipynb
.needle-python
package is required as an external dependency for accessing Needle's API. It has been added to the extended testing dependencies list.Add tests and docs: If you're adding a new integration, please include
NeedleRetriever
andNeedleLoader
inlibs/community/tests/unit_tests
. These tests mock API calls to avoid relying on network access.docs/docs/integrations/
, showcasing both retriever and loader functionality.Lint and test: Run
make format
,make lint
, andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/make format
: Passedmake lint
: Passedmake test
: Passed (requiresneedle-python
to be installed locally; this package is not added to LangChain dependencies).Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.