OneDriveLoader

[netoferraz]

Issue: #2153

• OneDriveLoader to extract documents from OneDrive.
• Files Supported: [doc, docx, pdf]

[netoferraz]

Hi @hwchase17 ! First of all, thanks for this great project. This is my first contribution, and I'm trying to dive deep into the details. This loader relies on O-365 package. Should I keep this as an optional dependency or include it in the pyproject.toml ?

[hwchase17]

Hi @hwchase17 ! First of all, thanks for this great project. This is my first contribution, and I'm trying to dive deep into the details. This loader relies on O-365 package. Should I keep this as an optional dependency or include it in the pyproject.toml ?

this is great! lets include as an optional dependency in the pyproject.toml file. that will mean both putting something like python-o365 = {version = "...", optional =True} as well as adding it to the list of packages in the extra_installs all section

i am happy to do these changes (along with others i point out in the pr) if you want - just let me know! it can be a bit tedious/confusing, but happy to let you slog through it if you want (you said you wanted to dive deep on the details). but, im very happy to do it for this pr so you can see the usual pr - let me know!

[hwchase17]

because this is optional, we don't want to do this at top of file (we only want to do it when needed).

if this is needed for linting, you can do

# top of file
from __future__ import annotations

from typing import TYPE_CHECKING
...

if TYPE_CHECKING:
     from O365 import...

if this is not for type hinting only, but rather you want to use it, you should do the imports in the functions themselves where they are used

[netoferraz]

Some of these imports are used within the functions and in the function signature. I've tried to move them into a _init_ method, but the interpreter still complains it cannot import it. I cannot make this work by moving those imports from the top. Would you happen to have any suggestions here?

[hwchase17]

lets expose this (and the file loader) in document_loaders/init.py

[netoferraz]

done.

[netoferraz]

Hi @hwchase17 ! First of all, thanks for this great project. This is my first contribution, and I'm trying to dive deep into the details. This loader relies on O-365 package. Should I keep this as an optional dependency or include it in the pyproject.toml ?

this is great! lets include as an optional dependency in the pyproject.toml file. that will mean both putting something like python-o365 = {version = "...", optional =True} as well as adding it to the list of packages in the extra_installs all section

i am happy to do these changes (along with others i point out in the pr) if you want - just let me know! it can be a bit tedious/confusing, but happy to let you slog through it if you want (you said you wanted to dive deep on the details). but, im very happy to do it for this pr so you can see the usual pr - let me know!

Done!

[hwchase17]

lgtm - i can fix issues