Add progress bar to filesystemblob loader, update pytest config for unit tests #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
changed the title
eyurtsev
commented
May 7, 2023
dev2049
reviewed
May 8, 2023
|
|
||
|
|
||
| def _make_iterator( | ||
| length_func: Callable[[], int], show_progress: bool = False |
There was a problem hiding this comment.
out of curiosity can length_func not just be called when passed into this function (so arg would just be length instead of length_func)
There was a problem hiding this comment.
It forces us to iterate through all the files on the file system, which is unnecessary if we're not using tqdm to show the progress. So we pass a function so we can calculate the length on the condition that we want to use tqdm
dev2049
approved these changes
May 8, 2023
EandrewJones
pushed a commit
to Oogway-Technologies/langchain
that referenced
this pull request
May 9, 2023
…nit tests (langchain-ai#4212) This PR adds: * Option to show a tqdm progress bar when using the file system blob loader * Update pytest run configuration to be stricter * Adding a new marker that checks that required pkgs exist
jpzhangvincent
pushed a commit
to jpzhangvincent/langchain
that referenced
this pull request
May 12, 2023
…nit tests (langchain-ai#4212) This PR adds: * Option to show a tqdm progress bar when using the file system blob loader * Update pytest run configuration to be stricter * Adding a new marker that checks that required pkgs exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: