You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from my understanding, the check_repeated_memory_variable validator will raise an error if any of the variables in the memories list are repeated. However, the load_memory_variables method does not check for repeated variables. This means that it is possible for the CombinedMemory instance to return a dictionary of memory variables that contains duplicate values. This code will check for repeated variables in the data dictionary returned by the load_memory_variables method of each sub-memory. If a repeated variable is found, an error will be raised.
from my understanding, the `check_repeated_memory_variable` validator will raise an error if any of the variables in the `memories` list are repeated. However, the `load_memory_variables` method does not check for repeated variables. This means that it is possible for the `CombinedMemory` instance to return a dictionary of memory variables that contains duplicate values. This code will check for repeated variables in the `data` dictionary returned by the `load_memory_variables` method of each sub-memory. If a repeated variable is found, an error will be raised.
from my understanding, the check_repeated_memory_variable validator will raise an error if any of the variables in the memories list are repeated. However, the load_memory_variables method does not check for repeated variables. This means that it is possible for the CombinedMemory instance to return a dictionary of memory variables that contains duplicate values. This code will check for repeated variables in the data dictionary returned by the load_memory_variables method of each sub-memory. If a repeated variable is found, an error will be raised.
dictionaries can't contain duplicate keys, so current logic would actually overwrite the stuff in memory_data with data if there was a duplicate. which idk if that's desirable either. thoughts @hwchase17?
🤖:bugRelated to a bug, vulnerability, unexpected error with an existing featurelgtmPR looks good. Use to confirm that a PR is ready for merging.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
the
🤖:bug
hwchase17
added
the
lgtm
from my understanding, the
check_repeated_memory_variablevalidator will raise an error if any of the variables in thememorieslist are repeated. However, theload_memory_variablesmethod does not check for repeated variables. This means that it is possible for theCombinedMemoryinstance to return a dictionary of memory variables that contains duplicate values. This code will check for repeated variables in thedatadictionary returned by theload_memory_variablesmethod of each sub-memory. If a repeated variable is found, an error will be raised.