Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from my understanding, the
check_repeated_memory_variable
validator will raise an error if any of the variables in thememories
list are repeated. However, theload_memory_variables
method does not check for repeated variables. This means that it is possible for theCombinedMemory
instance to return a dictionary of memory variables that contains duplicate values. This code will check for repeated variables in thedata
dictionary returned by theload_memory_variables
method of each sub-memory. If a repeated variable is found, an error will be raised.