Add Feedback ID (#98)

(already was done client side in the TS client)
langchain-ai · Jul 17, 2023 · a7ee3dc · a7ee3dc
2 parents 0b1725d + 65f02f0
commit a7ee3dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/python/langsmith/client.py b/python/langsmith/client.py
@@ -23,7 +23,7 @@
     cast,
 )
 from urllib.parse import urlsplit
-from uuid import UUID
+from uuid import UUID, uuid4
 
 from requests import ConnectionError, HTTPError, Response, Session
 from requests.adapters import HTTPAdapter
@@ -1372,6 +1372,7 @@ def create_feedback(
         else:
             raise ValueError(f"Unknown feedback source type {feedback_source_type}")
         feedback = FeedbackCreate(
+            id=uuid4(),
             run_id=run_id,
             key=key,
             score=score,

diff --git a/python/langsmith/schemas.py b/python/langsmith/schemas.py
@@ -156,7 +156,8 @@ class FeedbackSourceType(Enum):
 class FeedbackBase(BaseModel):
     """Feedback schema."""
 
-    id: Optional[UUID] = None
+    id: UUID
+    """The unique ID of the feedback."""
     created_at: Optional[datetime] = None
     """The time the feedback was created."""
     modified_at: Optional[datetime] = None