[JS] Anno crud #1010
Merged
[JS] Anno crud #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Sep 17, 2024
js/src/client.ts
Outdated
| */ | ||
| public async readAnnotationQueue(queueId: string): Promise<AnnotationQueue> { | ||
| // TODO: Replace when actual endpoint is added | ||
| const queue = await this.listAnnotationQueues({ |
There was a problem hiding this comment.
Naming is a bit funny here - getAnnotationQueue maybe?
readAnnotationQueue sounds like it should just return the items in the queue.
There was a problem hiding this comment.
ya.... I think for sake of consistency I'm gonna keep it though since we use read elsewhere
jacoblee93
reviewed
Sep 17, 2024
Add methods that are in the slots attribute to the functions list --------- Co-authored-by: Nick Huang <nickhuang@Nicks-MacBook-Pro.local>
hinthornw
force-pushed
the
wfh/anno
branch
3 times, most recently
from
a71423a
to
f3d3bd6
Compare
agola11
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to add tests