fix(js): Log instead of throw errors on 404

js/src/client.ts

@@ -724,7 +724,7 @@
       immediatelyTriggerBatch ||
       this.autoBatchQueue.size > this.pendingAutoBatchedRunLimit
     ) {
-      await this.drainAutoBatchQueue();
+      await this.drainAutoBatchQueue().catch(console.error);
     }
     if (this.autoBatchQueue.size > 0) {
       this.autoBatchTimeout = setTimeout(
@@ -1291,7 +1291,7 @@
     treeFilter?: string;
     isRoot?: boolean;
     dataSourceType?: string;
   }): Promise<any> {
     let projectIds_ = projectIds || [];
     if (projectNames) {
       projectIds_ = [
@@ -1579,7 +1579,7 @@
         `Failed to list shared examples: ${response.status} ${response.statusText}`
       );
     }
     return result.map((example: any) => ({
       ...example,
       _hostUrl: this.getHostUrl(),
     }));
@@ -2722,7 +2722,7 @@
     }
 
     const feedbackResult = await evaluator.evaluateRun(run_, referenceExample);
     const [_, feedbacks] = await this._logEvaluationFeedback(
       feedbackResult,
       run_,
       sourceInfo
@@ -3056,7 +3056,7 @@
   async _logEvaluationFeedback(
     evaluatorResponse: EvaluationResult | EvaluationResults,
     run?: Run,
     sourceInfo?: { [key: string]: any }
   ): Promise<[results: EvaluationResult[], feedbacks: Feedback[]]> {
     const evalResults: Array<EvaluationResult> =
       this._selectEvalResults(evaluatorResponse);
@@ -3095,7 +3095,7 @@
   public async logEvaluationFeedback(
     evaluatorResponse: EvaluationResult | EvaluationResults,
     run?: Run,
     sourceInfo?: { [key: string]: any }
   ): Promise<EvaluationResult[]> {
     const [results] = await this._logEvaluationFeedback(
       evaluatorResponse,
@@ -3363,7 +3363,7 @@
     promptIdentifier: string,
     like: boolean
   ): Promise<LikePromptResponse> {
     const [owner, promptName, _] = parsePromptIdentifier(promptIdentifier);
     const response = await this.caller.call(
       _getFetchImplementation(),
       `${this.apiUrl}/likes/${owner}/${promptName}`,
@@ -3468,7 +3468,7 @@
   }
 
   public async getPrompt(promptIdentifier: string): Promise<Prompt | null> {
     const [owner, promptName, _] = parsePromptIdentifier(promptIdentifier);
     const response = await this.caller.call(
       _getFetchImplementation(),
       `${this.apiUrl}/repos/${owner}/${promptName}`,
@@ -3512,7 +3512,7 @@
       );
     }
 
     const [owner, promptName, _] = parsePromptIdentifier(promptIdentifier);
     if (!(await this._currentTenantIsOwner(owner))) {
       throw await this._ownerConflictError("create a prompt", owner);
     }
@@ -3545,7 +3545,7 @@
 
   public async createCommit(
     promptIdentifier: string,
     object: any,
     options?: {
       parentCommitHash?: string;
     }
@@ -3554,7 +3554,7 @@
       throw new Error("Prompt does not exist, you must create it first.");
     }
 
     const [owner, promptName, _] = parsePromptIdentifier(promptIdentifier);
     const resolvedParentCommitHash =
       options?.parentCommitHash === "latest" || !options?.parentCommitHash
         ? await this._getLatestCommitHash(`${owner}/${promptName}`)

js/src/tests/traceable.test.ts

@@ -1,7 +1,9 @@
+import { jest } from "@jest/globals";
 import { RunTree, RunTreeConfig } from "../run_trees.js";
 import { ROOT, traceable, withRunTree } from "../traceable.js";
 import { getAssumedTreeFromCalls } from "./utils/tree.js";
 import { mockClient } from "./utils/mock_client.js";
+import { Client, overrideFetchImplementation } from "../index.js";
 
 test("basic traceable implementation", async () => {
   const { client, callSpy } = mockClient();
@@ -26,6 +28,37 @@ test("basic traceable implementation", async () => {
   });
 });
 
+test("404s should only log, not throw an error", async () => {
+  const overriddenFetch = jest.fn(() =>
+    Promise.resolve({
+      ok: false,
+      status: 404,
+      statusText: "Expected test error",
+      json: () => Promise.resolve({}),
+      text: () => Promise.resolve("Expected test error."),
+    })
+  );
+  overrideFetchImplementation(overriddenFetch);
+  const client = new Client({
+    apiUrl: "https://foobar.notreal",
+  });
+  const llm = traceable(
+    async function* llm(input: string) {
+      const response = input.repeat(2).split("");
+      for (const char of response) {
+        yield char;
+      }
+    },
+    { client, tracingEnabled: true }
+  );
+
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  for await (const _ of llm("Hello world")) {
+    // pass
+  }
+  expect(overriddenFetch).toHaveBeenCalled();
+});
+
 test("nested traceable implementation", async () => {
   const { client, callSpy } = mockClient();