-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): automatic handoff from Langchain RunnableLambda to traceable #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
approved these changes
Jul 16, 2024
dqbd
changed the title
feat(js): transparent handoff vol. 2
feat(js): automatic handoff from Langchain RunnableLambda to traceable
Jul 17, 2024
…into dqbd/transparent-handoff-vol2
agola11
added a commit
to langchain-ai/langsmith-docs
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now share RunTree tracing context with LangChain, accompanying PR: langchain-ai/langchainjs#5992
To preserve the tracing context in LangChain, we store the child RunnableConfig in the
extra[Symbol.for("lc:child_config")]
. As it's a symbol, it won't be sent to LangSmith.Before creating a child, we make sure that both
parentRunId
andrunMap
is appropriately updated when handing tracing fromtraceable
toLangChain
. The RunTree <-> LangChainTracer code has been moved to LangChain, however we still keep the code inlangsmith/langchain
for backwards compatibility.