feat: add hub js sdk to langsmith js sdk #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqbd
reviewed
Jul 25, 2024
dqbd
reviewed
Jul 26, 2024
| } | ||
| ); | ||
|
|
||
| if (response.status === 404) { |
There was a problem hiding this comment.
Should we also handle !res.ok as well?
dqbd
reviewed
Jul 26, 2024
| body: JSON.stringify(data), | ||
| signal: AbortSignal.timeout(this.timeout_ms), | ||
| ...this.fetchOptions, | ||
| }); |
There was a problem hiding this comment.
nit: should we handle !response.ok as well?
dqbd
reviewed
Jul 26, 2024
| }; | ||
| } | ||
|
|
||
| public async _pullPrompt( |
There was a problem hiding this comment.
nit: maybe worth adding @private JSDoc tag + indicate what user should do?
dqbd
reviewed
Jul 26, 2024
js/src/client.ts
Outdated
| }); | ||
| } | ||
|
|
||
| if (options?.object === null) { |
There was a problem hiding this comment.
Don't we need to check for undefined as well?
dqbd
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.