Add pagination #96
Merged
Add pagination #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqbd
reviewed
Jul 17, 2023
js/src/run_trees.ts
Outdated
| @@ -62,7 +62,7 @@ export class RunTree implements BaseRun { | |||
| api_key: getEnvironmentVariable("LANGCHAIN_API_KEY"), | |||
| caller_options: {}, | |||
| start_time: Date.now(), | |||
| end_time: Date.now(), | |||
| end_time: null, | |||
There was a problem hiding this comment.
nit: shouldn't that be undefined instead? Or maybe we should change end_time data type?
js/src/client.ts
Outdated
| @@ -108,6 +108,14 @@ const raiseForStatus = async (response: Response, operation: string) => { | |||
| } | |||
| }; | |||
|
|
|||
| export async function toArray<T>(iterable: AsyncIterable<T>): Promise<T[]> { | |||
There was a problem hiding this comment.
nit: do we want to expose this function to the outside? (ignore if we're just consuming it ourselves)
There was a problem hiding this comment.
Hm probably not to start ya
dqbd
reviewed
Jul 17, 2023
js/src/tests/client.int.test.ts
Outdated
| for await (const dataset of langchainClient.listDatasets({})) { | ||
| datasets.push(dataset); | ||
| } | ||
| if (datasets.some((dataset: any) => dataset.name === datasetName)) { |
There was a problem hiding this comment.
nit: Using toArray we would be able to get rid of any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.