Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Application Crash with Multiple Nested Dict Components in Flow #2011

Merged
merged 3 commits into from
May 30, 2024

Conversation

Cristhianzl
Copy link
Member

  • Fixed Infinite Render Loop: Removed redundant useEffect hooks that were causing infinite re-renders in React.

  • Unified Data Source: Modified the editNodeModal and parametersComponent to pull information from a single source, ensuring synchronized value updates across both components.

  • Local Testing: All tests passed successfully on the local environment.

🐛 (parameterComponent): remove unnecessary console.log statement
♻️ (editNodeModal): refactor to use nodeId instead of passing data directly
…etter data handling

♻️ (nodeToolbarComponent): refactor to improve code readability and consistency
@Cristhianzl Cristhianzl self-assigned this May 30, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 30, 2024
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 1:20am

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2024
@ogabrielluiz ogabrielluiz merged commit fb018ed into dev May 30, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants