-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: api keys API #2652
Merged
Merged
refactor: api keys API #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jul 12, 2024
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 12 Jul 24 05:33 UTC |
Cristhianzl
reviewed
Jul 12, 2024
src/frontend/src/controllers/API/queries/api-keys/use-delete-api-key.ts
Outdated
Show resolved
Hide resolved
src/frontend/src/controllers/API/queries/api-keys/use-get-api-keys.ts
Outdated
Show resolved
Hide resolved
anovazzi1
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anovazzi1
force-pushed
the
refactor/getApiKeys
branch
from
July 18, 2024 20:31
5713687
to
1c66dce
Compare
… react ref to ensure component render
anovazzi1
force-pushed
the
refactor/getApiKeys
branch
from
July 22, 2024 14:53
1c66dce
to
6bc38a6
Compare
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
* feat: create useDeleteApiKey hook to handle api keys delete * refactor: use mutation to handle delete api key * [autofix.ci] apply automated fixes * feat: create useGetApiKeys hook * refactor: use useGetApiKeysQuery hook to get api keys data * [autofix.ci] apply automated fixes * refactor: change interface name * refactor: remove unnused loading state and use react state instead of react ref to ensure component render * fix: multiple refreshs when auto_login=false --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 6fa3c7b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new custom hook useGetApiKeys to streamline the process of fetching API keys data. The useGetApiKeys hook encapsulates the logic for retrieving API keys, providing a cleaner and more reusable way to access this data across the application.