Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update model names for backwards compatibility #3014

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request updates the model names in openai_constants.py to ensure backwards compatibility. The OPENAI_MODEL_NAMES and OPENAI_EMBEDDING_MODEL_NAMES lists have been modified to include additional models. Additionally, a new MODEL_NAMES list has been added for backwards compatibility.

@ogabrielluiz ogabrielluiz requested a review from namastex888 July 28, 2024 18:32
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. python Pull requests that update Python code labels Jul 28, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 28 Jul 24 18:32 UTC

@github-actions github-actions bot added the bug Something isn't working label Jul 28, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3014.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 28, 2024 18:35
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@ogabrielluiz ogabrielluiz merged commit e5885ab into main Jul 29, 2024
65 of 67 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/modelnamesbc branch July 29, 2024 04:18
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
chore: update model names in openai_constants.py for backwards compatibility
(cherry picked from commit e5885ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants