Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create Frontend feature flags #3029

Merged
merged 15 commits into from
Jul 30, 2024

Conversation

mfortman11
Copy link
Collaborator

First iteration of #2814

To improve the process of keeping DataStax Langflow in sync w/ OSS

This PR wraps some of the simpler features to be easily toggled on and off via the JSON file

These feature are:

  • ENABLE_DARK_MODE - DS portal doesn't yet support dark mode so we turn this off more a more uniform experience
  • ENABLE_API - Hides the API button to get info on how to call your flow via the REST endpoint
  • ENABLE_LANGFLOW_STORE - Auto set hasStore to false if this is false
  • ENABLE_PROFILE_ICONS - DS already had profile images 2 sets of them aren't needed

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 14:21 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3029.dmtpw4p5recq1.amplifyapp.com

@mfortman11 mfortman11 requested a review from anovazzi1 July 29, 2024 17:51
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@ogabrielluiz ogabrielluiz changed the title Feature: Create Frontend feature flags feat: create Frontend feature flags Jul 30, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 30, 2024
@ogabrielluiz ogabrielluiz merged commit 72ff6d3 into langflow-ai:main Jul 30, 2024
32 checks passed
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
* Add UI feature flag config

* [autofix.ci] apply automated fixes

* hide general settings if there is nothing to show

* make sure to handle !autoLogin case

* [autofix.ci] apply automated fixes

* missed commit

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: anovazzi1 <otavio2204@gmail.com>
(cherry picked from commit 72ff6d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants