Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tool calling and openai tools do not include chat history #3030

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

nicoloboschi
Copy link
Contributor

fixes #2864

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 15:36 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3030.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 29, 2024 21:32
The code changes involve updating the imports in the `agent.py`, `OpenAIToolsAgent.py`, and `ToolCallingAgent.py` files to use the `Data` class from the `langflow.schema` module instead of the `Data` class from the `langflow.field_typing` module. This change ensures consistency and improves code readability.

Note: This commit message follows the established convention of starting with a type (feat, fix, chore) followed by a brief description of the changes.
@ogabrielluiz ogabrielluiz merged commit 5306395 into langflow-ai:main Jul 29, 2024
50 checks passed
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
…low-ai#3030)

* fix: tool calling and openai tools do not include chat history

* fix import

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 5306395)
ogabrielluiz pushed a commit that referenced this pull request Jul 30, 2024
* fix: tool calling and openai tools do not include chat history

* fix import

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Not Passed as Chat History in Tool Calling Agent
2 participants