Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move client instantiation in AssistantsGetAssistantName and AssistantsListAssistants to inner function #3043

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

ogabrielluiz
Copy link
Contributor

The OpenAI client instantiation was removed from the AssistantsGetAssistantName and AssistantsListAssistants components. This commit fixes the issue by adding back the OpenAI client instantiation in the process_inputs method of both components.

…stantsListAssistants to inner function

The OpenAI client instantiation was removed from the `AssistantsGetAssistantName` and `AssistantsListAssistants` components. This commit fixes the issue by adding back the OpenAI client instantiation in the `process_inputs` method of both components.
@ogabrielluiz ogabrielluiz requested a review from anovazzi1 July 29, 2024 20:08
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 29, 2024 20:08
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 20:08 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 29, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3043.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz merged commit c63876f into main Jul 29, 2024
65 of 67 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/astraassistantspatch branch July 29, 2024 20:28
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
…stantsListAssistants to inner function (langflow-ai#3043)

The OpenAI client instantiation was removed from the `AssistantsGetAssistantName` and `AssistantsListAssistants` components. This commit fixes the issue by adding back the OpenAI client instantiation in the `process_inputs` method of both components.

(cherry picked from commit c63876f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants