Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FlowTool.py): update FlowToolComponent class to inherit from LCToolComponent #3048

Merged
merged 10 commits into from
Jul 30, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Updates FlowToolComponent to the new Component architecture.

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 29, 2024 22:49
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. python Pull requests that update Python code and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 29 Jul 24 22:50 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3048.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@vasconceloscezar
Copy link
Collaborator

Not able to use the search option to find flows:

image

image

@vasconceloscezar
Copy link
Collaborator

The Dropdown is also allowing the user to select multiple flows (and none of them appears as selected in the field)

https://jam.dev/c/6ad09f07-a670-4471-8b98-c0814f515617

And another bug just ocurred after this.

I switched back to the Langflow tab, got an "Unexpected Error", and the component showed a Warning sign to update it.

After updating it, the dropdown to select flows stopped working.

https://jam.dev/c/161f2b66-80b3-4fab-964b-c1474f39a911

That was wierd bc I didn't touch the backend, so there was no update or pull, between those two videos.

@ogabrielluiz ogabrielluiz merged commit 8bc45b9 into main Jul 30, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/flowtool branch July 30, 2024 20:47
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
… LCToolComponent (langflow-ai#3048)

* refactor(utils.py): simplify data processing logic in build_data_from_result_data function for better readability and maintainability

* feat: set default output type to "chat" in run_flow function

* refactor(FlowTool.py): refactor FlowToolComponent class to inherit from LCToolComponent

* Fixed Flow as Tool component

* Fixed FlowTool to only output tool and removed async function def

* [autofix.ci] apply automated fixes

* Fixed lint

---------

Co-authored-by: Lucas Oliveira <62335616+lucaseduoli@users.noreply.github.com>
Co-authored-by: Lucas Oliveira <lucas.edu.oli@hotmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 8bc45b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants