Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node alert to detect outdated components #3051

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

anovazzi1
Copy link
Contributor

The updateComponentsToUpdate function in flowStore.ts has been updated to properly check for outdated nodes. This ensures that components are only updated when necessary, improving performance and preventing unnecessary re-renders.

The `updateComponentsToUpdate` function in `flowStore.ts` has been updated to properly check for outdated nodes. This ensures that components are only updated when necessary, improving performance and preventing unnecessary re-renders.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 29, 2024
@anovazzi1 anovazzi1 changed the title UpdateNodeAlert fix: updateNodeAlert Jul 29, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 23:42 UTC

@anovazzi1 anovazzi1 requested a review from ogabrielluiz July 29, 2024 23:42
@github-actions github-actions bot added the bug Something isn't working label Jul 29, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
@anovazzi1 anovazzi1 changed the title fix: updateNodeAlert fix:updat node alert to detect outdated components Jul 29, 2024
@anovazzi1 anovazzi1 changed the title fix:updat node alert to detect outdated components fix:update node alert to detect outdated components Jul 29, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3051.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz changed the title fix:update node alert to detect outdated components fix: update node alert to detect outdated components Jul 30, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 30, 2024
anovazzi1 and others added 2 commits July 30, 2024 13:15
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
@anovazzi1 anovazzi1 requested a review from ogabrielluiz July 30, 2024 16:16
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 30, 2024 16:27
@ogabrielluiz ogabrielluiz merged commit 69c089a into main Jul 30, 2024
37 of 38 checks passed
@ogabrielluiz ogabrielluiz deleted the updateNodeAlert branch July 30, 2024 16:39
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
* check nodes to update on build flow

* feat: update componentsToUpdate logic in flowStore.ts

The `updateComponentsToUpdate` function in `flowStore.ts` has been updated to properly check for outdated nodes. This ensures that components are only updated when necessary, improving performance and preventing unnecessary re-renders.

* [autofix.ci] apply automated fixes

* Update src/frontend/src/stores/flowStore.ts

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
(cherry picked from commit 69c089a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants