-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change user's endpoints requests to use useQuery #3088
Conversation
🔧 (API/index.ts): Remove unused functions addUser, deleteUser, updateUser, resetPassword 🔧 (use-delete-users.ts): Rename useDeleteMessages to useDeleteUsers 🔧 (AdminPage/index.tsx): Update pageSize state from 10 to 12, refactor handleDeleteUser, handleEditUser, handleDisableUser, handleSuperUserEdit, handleNewUser functions to use mutation functions from API/queries/auth instead of direct API calls ✨ (ProfileSettingsPage): Introduce new queries for resetting password and updating user profile in ProfileSettingsPage 📝 (ProfileSettingsPage): Add error handling and success handling functions for password reset and profile update 📝 (ProfileSettingsPage): Update function to handle user input for password and profile picture changes 📝 (ProfilePictureChooserComponent): Update optional props for profilePictures and loading in ProfilePictureChooserComponent 📝 (GeneralPage): Add constants for alerts and queries for resetting password and updating user in GeneralPage 📝 (GeneralPage): Update functions to handle password patching and profile picture patching in GeneralPage 🔧 (use-patch-gradient.tsx): Remove use-patch-gradient hook file 🔧 (use-patch-password.tsx): Remove use-patch-password hook file 🔧 (use-patch-profile-picture.tsx): Remove unused code related to updating profile picture functionality ✨ (index.tsx): Replace addUser function with useAddUser hook for adding a new user during sign up process 📝 (index.ts): Add 'gradient' property to patchUserInputStateType interface for future use in components
…ement ♻️ (paginatorComponent/index.tsx): remove defaultValue prop from Select component as it is redundant and not needed
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 30 Jul 24 19:06 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request will change user's requests to use useQuery lib.
📝 (paginatorComponent/index.tsx): Add console log for pageSize variable
🔧 (API/index.ts): Remove unused functions addUser, deleteUser, updateUser, resetPassword
🔧 (use-delete-users.ts): Rename useDeleteMessages to useDeleteUsers
🔧 (AdminPage/index.tsx): Update pageSize state from 10 to 12, refactor handleDeleteUser, handleEditUser, handleDisableUser, handleSuperUserEdit, handleNewUser functions to use mutation functions from API/queries/auth instead of direct API calls
✨ (ProfileSettingsPage): Introduce new queries for resetting password and updating user profile in ProfileSettingsPage
📝 (ProfileSettingsPage): Add error handling and success handling functions for password reset and profile update
📝 (ProfileSettingsPage): Update function to handle user input for password and profile picture changes
📝 (ProfilePictureChooserComponent): Update optional props for profilePictures and loading in ProfilePictureChooserComponent
📝 (GeneralPage): Add constants for alerts and queries for resetting password and updating user in GeneralPage
📝 (GeneralPage): Update functions to handle password patching and profile picture patching in GeneralPage
🔧 (use-patch-gradient.tsx): Remove use-patch-gradient hook file
🔧 (use-patch-password.tsx): Remove use-patch-password hook file
🔧 (use-patch-profile-picture.tsx): Remove unused code related to updating profile picture functionality
✨ (index.tsx): Replace addUser function with useAddUser hook for adding a new user during sign up process
📝 (index.ts): Add 'gradient' property to patchUserInputStateType interface for future use in components