Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unnecessary condition in App component #3107

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

The unnecessary condition in the App component was causing the error modal to not appear when there was an error in the health data. This commit removes the unnecessary condition to ensure that the error modal is displayed correctly.

The unnecessary condition in the App component was causing the error modal to not appear when there was an error in the health data. This commit removes the unnecessary condition to ensure that the error modal is displayed correctly.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working javascript Pull requests that update Javascript code labels Jul 31, 2024
@anovazzi1 anovazzi1 requested a review from ogabrielluiz July 31, 2024 12:53
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 31 Jul 24 12:56 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3107.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added enhancement New feature or request and removed bug Something isn't working labels Jul 31, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) July 31, 2024 13:09
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 31, 2024
@anovazzi1 anovazzi1 merged commit 7276f69 into main Jul 31, 2024
30 checks passed
@anovazzi1 anovazzi1 deleted the fixHealth branch July 31, 2024 14:24
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
The unnecessary condition in the App component was causing the error modal to not appear when there was an error in the health data. This commit removes the unnecessary condition to ensure that the error modal is displayed correctly.

(cherry picked from commit 7276f69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants