Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: global variables logic #3144

Merged
merged 26 commits into from
Aug 1, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

  • Passed the global variables state to be handled by ReactQuery
  • Refactored global variables gathering functions
  • Fix global variables not appearing on autoLogin=false

@lucaseduoli lucaseduoli requested a review from Cristhianzl August 1, 2024 14:17
@lucaseduoli lucaseduoli self-assigned this Aug 1, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working javascript Pull requests that update Javascript code labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 01 Aug 24 14:18 UTC

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed bug Something isn't working labels Aug 1, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3144.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) August 1, 2024 15:56
@lucaseduoli lucaseduoli merged commit 83e48af into main Aug 1, 2024
49 checks passed
@lucaseduoli lucaseduoli deleted the fix/global_variables_not_appearing branch August 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants