Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update graph visualization and add ASCII representation #3219

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request includes several refactorings and enhancements to the graph visualization capabilities. The Graph class now has a method to convert the graph to the NetworkX format, allowing for enhanced graph visualization. A unit test has been added to ensure proper node and edge representation in the conversion. The dependencies in the poetry files have been updated, adding the grandalf library version 0.8.0. Additionally, ASCII graph drawing functionality has been implemented using the grandalf library. A deprecated test for the Graph to NetworkX conversion has been removed. The Graph representation format has been improved, and an ASCII visualization method has been added to enhance readability and usability.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 06 Aug 24 21:24 UTC

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Aug 6, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat/visualize-graph branch from 64f0d3f to 225531b Compare August 7, 2024 13:29
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
Base automatically changed from feat/elkjslayout to main August 7, 2024 14:04
An error occurred while trying to automatically change base from feat/elkjslayout to main August 7, 2024 14:04
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 7, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Aug 7, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 7, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat/visualize-graph branch from 9805490 to 5a24d5a Compare August 7, 2024 18:32
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 7, 2024 18:32
@ogabrielluiz ogabrielluiz merged commit 72463d9 into main Aug 7, 2024
49 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/visualize-graph branch August 7, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants