Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve layout options and make sure nodes and flow have position data #3231

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This PR adds call to processDataFromFlow when pasting and makes sure fitView is called if flows don't have position data.

@ogabrielluiz ogabrielluiz requested a review from anovazzi1 August 7, 2024 18:18
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 07 Aug 24 18:18 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 7, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3231.dmtpw4p5recq1.amplifyapp.com

…ering and add debug logs for layout verification
The PageComponent in the FlowPage now fits the view when the viewport is at (0,0). This improves the initial display of the page and enhances the user experience.
…g upload, improving data processing efficiency
…nent layout and consistency in the user interface
@ogabrielluiz ogabrielluiz force-pushed the feat/importtwographs branch from 507e05a to ecd08d0 Compare August 7, 2024 18:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove those console.logs?

@ogabrielluiz ogabrielluiz force-pushed the feat/importtwographs branch from ad0aa31 to 46286f6 Compare August 7, 2024 19:29
@anovazzi1 anovazzi1 self-requested a review August 7, 2024 19:29
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat/importtwographs branch from 46286f6 to ad0aa31 Compare August 7, 2024 19:31
@ogabrielluiz ogabrielluiz merged commit 0ac7845 into main Aug 7, 2024
32 of 39 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/importtwographs branch August 7, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants