Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve NodeOutputField and NodeInputField components #3235

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

anovazzi1
Copy link
Contributor

Refactored the NodeOutputField component in the GenericNode file to improve code organization and readability. Also refactored the NodeInputField component in the GenericNode file to remove unnecessary code and improve performance. These changes enhance the overall maintainability and efficiency of the codebase.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Aug 7, 2024
@anovazzi1 anovazzi1 requested a review from lucaseduoli August 7, 2024 21:38
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 07 Aug 24 21:38 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3235.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz changed the title Refactor NodeOutputField and NodeInputField components refactor: create NodeOutputField and NodeInputField components Aug 8, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 8, 2024
@anovazzi1 anovazzi1 changed the title refactor: create NodeOutputField and NodeInputField components refactor: improve NodeOutputField and NodeInputField components Aug 8, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Aug 8, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove console logs

@anovazzi1 anovazzi1 requested a review from lucaseduoli August 13, 2024 16:51
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@anovazzi1 anovazzi1 merged commit 62b1b88 into main Aug 13, 2024
36 of 37 checks passed
@anovazzi1 anovazzi1 deleted the improveNodeInputsAndOutputs branch August 13, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants