Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log_builds parameter to build_flow for optional vertex build logging #3262

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This is needed so that calls from outside the workspace don't affect the playground in the workspace.

log_builds should be used as a query param just like start_component_id.

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 9, 2024 12:30
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Aug 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3262.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 09 Aug 24 12:41 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 9, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat/conditionalbuildlogs branch from 0b0d664 to 6b18ec7 Compare August 9, 2024 14:02
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@ogabrielluiz ogabrielluiz merged commit b0f80e4 into main Aug 9, 2024
56 of 57 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/conditionalbuildlogs branch August 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants