Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: centralize global variable management #3284

Merged
merged 16 commits into from
Aug 13, 2024
Merged

Conversation

italojohnny
Copy link
Member

This PR focuses on enhancing code cohesion in the management of global variables by removing the logic from the API and utilizing the existing interface for this purpose. Unit tests were added to ensure that the refactoring did not alter the current behavior of the code.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Aug 12, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 12 Aug 24 08:27 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3284.dmtpw4p5recq1.amplifyapp.com

@italojohnny italojohnny changed the title Centralize Global Variable Management feature: centralize global variable management Aug 12, 2024
@italojohnny italojohnny changed the title feature: centralize global variable management feat: centralize global variable management Aug 12, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 12, 2024
@ogabrielluiz ogabrielluiz force-pushed the refactor/global_variables branch from 71f379a to f3958d6 Compare August 12, 2024 19:20
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
@italojohnny italojohnny enabled auto-merge (squash) August 12, 2024 21:02
@italojohnny italojohnny merged commit 952ba5e into main Aug 13, 2024
49 of 50 checks passed
@italojohnny italojohnny deleted the refactor/global_variables branch August 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants