-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: centralize global variable management #3284
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 12 Aug 24 08:27 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
71f379a
to
f3958d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…d delete_variable_by_id method
…able_by_id method.
This PR focuses on enhancing code cohesion in the management of global variables by removing the logic from the API and utilizing the existing interface for this purpose. Unit tests were added to ensure that the refactoring did not alter the current behavior of the code.