Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve node toolbar code #3311

Merged
merged 30 commits into from
Aug 14, 2024
Merged

refactor: improve node toolbar code #3311

merged 30 commits into from
Aug 14, 2024

Conversation

anovazzi1
Copy link
Contributor

key features:

  • create a custom hook for shortcuts
  • create a react component to render shortcut hint
  • remove useless logic

anovazzi1 and others added 22 commits August 7, 2024 19:22
@anovazzi1 anovazzi1 requested a review from lucaseduoli August 13, 2024 19:46
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. javascript Pull requests that update Javascript code labels Aug 13, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 13 Aug 24 19:47 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 13, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3311.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot removed the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 13, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 13, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) August 13, 2024 23:03
@anovazzi1 anovazzi1 merged commit 7fe6c53 into main Aug 14, 2024
30 checks passed
@anovazzi1 anovazzi1 deleted the refactorNodeToolbar branch August 14, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants