Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update keyboard shortcuts display #3316

Merged
merged 44 commits into from
Aug 14, 2024
Merged

refactor: update keyboard shortcuts display #3316

merged 44 commits into from
Aug 14, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request includes several commits that refactor the keyboard shortcuts functionality. The commits remove unused code, add new components and improve keyboard shortcuts handling. The pull request also includes updates to various files and the addition of a new constant for shortcut keys. These changes aim to improve the overall functionality and user experience of the node shortcuts.

anovazzi1 and others added 30 commits August 7, 2024 19:22
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 13, 2024
@anovazzi1 anovazzi1 requested a review from lucaseduoli August 13, 2024 22:21
@dosubot dosubot bot added enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 13, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 13 Aug 24 22:23 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3316.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
alexleventer and others added 2 commits August 13, 2024 19:47
* Update link in README.md

* Update README.md

* Update getting-started-installation.md

* Update README.KR.md

* Update README.ja.md
@ogabrielluiz ogabrielluiz changed the title Refactor keyboard shortcuts display refactor: update keyboard shortcuts display Aug 14, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Aug 14, 2024
anovazzi1 and others added 10 commits August 14, 2024 11:27
* feat: Google Drive Search Component

feat: Google Drive Search Component
Ability to search Google Drive and get back the relevant Doc id or Doc urls

* Updated Google Drive Search.py
…sh Vector component (#3254)

* feat: add metadata filtering and namespace support for the upstash vector component

* docs: add upstash vector to the vectorstores doc

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 14, 2024
@anovazzi1 anovazzi1 merged commit 0e2f277 into main Aug 14, 2024
30 of 37 checks passed
@anovazzi1 anovazzi1 deleted the fixShortcutRender branch August 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants