fix: improve end_traces so it doesn't block the build loop #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o.to_thread. This is an attempt to avoid blocking the build loop
dosubot
bot
added
size:S
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 21 Aug 24 20:01 UTC |
github-actions
bot
added
bug
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
italojohnny
approved these changes
Aug 21, 2024
ogabrielluiz
deleted the
fix-improve-end_traces-so-it-doesn't-block-the-build-loop
branch
anovazzi1
pushed a commit
that referenced
this pull request
Aug 26, 2024
* refactor: Simplify log configuration logic in Graph class * feat(tracing): Refactor _end_traces method to be async and use asyncio.to_thread. This is an attempt to avoid blocking the build loop
ogabrielluiz
added a commit
that referenced
this pull request
Aug 27, 2024
* refactor: Simplify log configuration logic in Graph class * feat(tracing): Refactor _end_traces method to be async and use asyncio.to_thread. This is an attempt to avoid blocking the build loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing a weird bug that causes the build loop to freeze and the logging to break.