-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix dropdown components test #3504
Conversation
…onent to improve test coverage and ensure functionality 🔧 (dropdownComponent.spec.ts): update test case to include additional interactions with the page to simulate user behavior and improve test robustness
…800 to improve test reliability 📝 (dropdownComponent.spec.ts): add additional wait time to ensure stability in test execution
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 22 Aug 24 13:25 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ering and scrolling in the dropdown component test to improve test readability and maintainability
* ✅ (dropdownComponent.spec.ts): add missing test case for dropdownComponent to improve test coverage and ensure functionality 🔧 (dropdownComponent.spec.ts): update test case to include additional interactions with the page to simulate user behavior and improve test robustness * ✅ (dropdownComponent.spec.ts): update mouse wheel scroll distance to 800 to improve test reliability 📝 (dropdownComponent.spec.ts): add additional wait time to ensure stability in test execution * 🔧 (dropdownComponent.spec.ts): remove unnecessary code related to hovering and scrolling in the dropdown component test to improve test readability and maintainability
* ✅ (dropdownComponent.spec.ts): add missing test case for dropdownComponent to improve test coverage and ensure functionality 🔧 (dropdownComponent.spec.ts): update test case to include additional interactions with the page to simulate user behavior and improve test robustness * ✅ (dropdownComponent.spec.ts): update mouse wheel scroll distance to 800 to improve test reliability 📝 (dropdownComponent.spec.ts): add additional wait time to ensure stability in test execution * 🔧 (dropdownComponent.spec.ts): remove unnecessary code related to hovering and scrolling in the dropdown component test to improve test readability and maintainability
This pull request fixes the Dropdown Component test, which broke due to recent updates to the component.
The tests have been updated accordingly.