-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: console reported issues #3660
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Hey @lucaseduoli Should any of these fixes close any issue? |
Hello @ogabrielluiz ! They currently don't close any issues, but were getting on the way of the development process, since the errors obfuscated the important ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Added key to sidebar buttons * Added key directrly to sidebar category * Removed key definition on sidebar category * Fix error of nested buttons on secretKeyModal * Fix nested buttons on output modal * Fix clip-path warning on components * Fix components cannot be given refs on nodeOutputField * Removed unused console.log * Added key on profile pictures map * Fixed hideOverlay being called when the table is destroyed * Fixed valueFormatter error on Apply To Fields field on GlobalVariables page * Updated headers on config page to ensure consistent design
This pull request includes several commits that fix various issues and improve the code quality of the project. Here are the highlights:
Added a key to sidebar buttons to improve performance.
Fixed an error with nested buttons on the secretKeyModal.
Fixed an issue with nested buttons on the output modal.
Fixed a clip-path warning on components.
Fixed an issue where components could not be given refs on nodeOutputField.
Removed an unused console.log statement.
Added a key on profile pictures map to improve performance.
Fixed an issue where hideOverlay was being called when the table is destroyed.
Fixed an error with valueFormatter on the Apply To Fields field on the GlobalVariables page.
Updated headers on the config page to ensure consistent design.
These changes address various bugs and improve the overall code quality of the project.