Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console reported issues #3660

Merged
merged 12 commits into from
Sep 2, 2024
Merged

fix: console reported issues #3660

merged 12 commits into from
Sep 2, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes several commits that fix various issues and improve the code quality of the project. Here are the highlights:

  • Added a key to sidebar buttons to improve performance.

  • Fixed an error with nested buttons on the secretKeyModal.

  • Fixed an issue with nested buttons on the output modal.

  • Fixed a clip-path warning on components.

  • Fixed an issue where components could not be given refs on nodeOutputField.

  • Removed an unused console.log statement.

  • Added a key on profile pictures map to improve performance.

  • Fixed an issue where hideOverlay was being called when the table is destroyed.

  • Fixed an error with valueFormatter on the Apply To Fields field on the GlobalVariables page.

  • Updated headers on the config page to ensure consistent design.

These changes address various bugs and improve the overall code quality of the project.

@lucaseduoli lucaseduoli self-assigned this Sep 2, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 2, 2024 20:33
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Sep 2, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 2, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3660.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz
Copy link
Contributor

Hey @lucaseduoli

Should any of these fixes close any issue?

@lucaseduoli
Copy link
Collaborator Author

Hello @ogabrielluiz !

They currently don't close any issues, but were getting on the way of the development process, since the errors obfuscated the important ones.

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@lucaseduoli lucaseduoli merged commit f2abb94 into main Sep 2, 2024
35 of 37 checks passed
@lucaseduoli lucaseduoli deleted the fix/key_errors branch September 2, 2024 21:48
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Added key to sidebar buttons

* Added key directrly to sidebar category

* Removed key definition on sidebar category

* Fix error of nested buttons on secretKeyModal

* Fix nested buttons on output modal

* Fix clip-path warning on components

* Fix components cannot be given refs on nodeOutputField

* Removed unused console.log

* Added key on profile pictures map

* Fixed hideOverlay being called when the table is destroyed

* Fixed valueFormatter error on Apply To Fields field on GlobalVariables page

* Updated headers on config page to ensure consistent design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants