Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iomodal and folders api calls #3661

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

Fixed an issue where the IOModal was calling the getMessages API again unnecessarily. Also fixed an issue where the folders API was being called twice. These changes ensure that the API calls are made only when necessary, improving performance and reducing unnecessary network requests.

@lucaseduoli lucaseduoli self-assigned this Sep 2, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 2, 2024 21:04
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working javascript Pull requests that update Javascript code labels Sep 2, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 2, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3661.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli requested review from Cristhianzl and removed request for anovazzi1 September 3, 2024 14:24
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 3, 2024
@lucaseduoli lucaseduoli merged commit 27ad129 into main Sep 3, 2024
28 checks passed
@lucaseduoli lucaseduoli deleted the fix/duplicate_requests branch September 3, 2024 17:29
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Fixed IOModal calling getMessages again

* Fixed folders API being called twice

* removed unused imports

* Re-added query of get messages and changed to enable query when open

* Fix auto login off test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants