fix: update saving behavior when exiting flow #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…confirmation and cancel does not exist
…to set loading as true when autoSave is off and the user saves
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* Updated save flow to only execute when the flow has unsaved changes * Made flowPage call saveFlow immediatly when trying to exit page * Changed save changes modal to automatically exit when saved on autoSave * Changed flowPage to save and exit when autoSave * Remove confirmation button if it does not exist and remove footer if confirmation and cancel does not exist * Changed saveChangesModal to not show buttons when autoSave is on and to set loading as true when autoSave is off and the user saves * Add timer to close modal, so, if saving takes less than 1 second, it waits * Changed type of confirmationModal * Added handling for when it's building and there is unsaved changes * Added success toast when flow finishes saving * refactored confirmationModal * check autoLogin !== undefined before calling things * Fix use save flow to compare the passed flow instead of the current one * Changed style of save changes modal * deleted build in progress modal * Removed build in progress modal, just stopping the build * Fix condition on api * Changed condition to be autoLogin !== undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The save flow behavior has been updated to only execute when there are unsaved changes in the flow. Additionally, the flowPage now calls saveFlow immediately when trying to exit the page. This improves the user experience by reducing unnecessary save requests and ensuring that changes are saved promptly.