Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Makefile to conditionally enable --reload based on worker count #3675

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request updates the Makefile to conditionally enable the --reload flag based on the worker count. It also handles backend port kill errors.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 3, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3675.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added the bug Something isn't working label Sep 3, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 3, 2024
@anovazzi1 anovazzi1 merged commit 6388883 into main Sep 3, 2024
17 of 18 checks passed
@anovazzi1 anovazzi1 deleted the fix/makebackend branch September 3, 2024 20:58
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
… count (langflow-ai#3675)

* Update Makefile to handle backend port kill errors

* Update Makefile to conditionally enable --reload based on worker count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants