Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a better scroll behave on playground's chat #3680

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request adds the useUtilityStore hook to the IOModal component for managing the scroll behavior of the playground in the application. It also includes the setPlaygroundScrollBehaves function to update the playgroundScrollBehaves property in the UtilityStoreType. This allows for setting the scroll behavior of the playground to either "instant" or "smooth".

…to `UtilityStoreType`

The `UtilityStoreType` now includes the `playgroundScrollBehaves` property of type `ScrollBehavior` and the `setPlaygroundScrollBehaves` function to update it. This allows for managing the scroll behavior of the playground in the application.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 4, 2024
@dosubot dosubot bot added the enhancement New feature or request label Sep 4, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 4, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3680.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@Cristhianzl Cristhianzl merged commit 835559a into main Sep 6, 2024
26 of 27 checks passed
@Cristhianzl Cristhianzl deleted the cz/ux-playground-scroll branch September 6, 2024 17:49
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* feat: Add useUtilityStore hook to IOModal for setting playground scroll behavior

* feat: Add useUtilityStore hook to IOModal for setting playground scroll behavior

* feat: Add setPlaygroundScrollBehaves function to useUtilityStore hook

* feat: Update codeTabsPropsType to allow undefined for the 'open' property

* feat: Add `playgroundScrollBehaves` and `setPlaygroundScrollBehaves` to `UtilityStoreType`

The `UtilityStoreType` now includes the `playgroundScrollBehaves` property of type `ScrollBehavior` and the `setPlaygroundScrollBehaves` function to update it. This allows for managing the scroll behavior of the playground in the application.

* refactor: Remove unused 'open' prop from CodeTabsComponent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants