Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build in progress modal when trying to exit #3695

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request adds a new modal component called BuildInProgressModal, which is displayed when a build is in progress and the user tries to exit. The modal allows the user to stop the build process. Additionally, the stopBuilding function in the FlowStore has been updated to set the isBuilding state to false after aborting the build.

@lucaseduoli lucaseduoli self-assigned this Sep 5, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 5, 2024 13:34
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 5, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 5, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3695.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli merged commit a4dc538 into main Sep 5, 2024
29 of 30 checks passed
@lucaseduoli lucaseduoli deleted the feat/build_blocker branch September 5, 2024 13:50
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Changed store to stop the isBuilding state as well

* Create Build In Progress modal

* Use blocker to stop if its building as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants