feature: add edit option to global variables table #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te its usage The component AddNewVariableButton has been renamed to GlobalVariableModal to better reflect its purpose. The component is now used in multiple places, including the GlobalVariablesPage and InputGlobalComponent. This change improves code clarity and consistency.
…VariableModal and GlobalVariablesPage Trim field names before checking for availability in GlobalVariableModal and GlobalVariablesPage to ensure consistent comparison and avoid any potential issues with leading or trailing spaces.
dosubot
bot
added
the
size:L
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…DENTIAL_TYPE - Introduced a field validator for the 'value' field in the VariableRead model to handle cases where the variable type is CREDENTIAL_TYPE. - Added necessary import for CREDENTIAL_TYPE. - Removed an unnecessary blank line in the variable API.
- Changed import of `CREDENTIAL_TYPE` from `service` to `constants` module. - Reordered fields in `VariableRead` model to place `type` before `value`.
…ting purposes 📝 (userSettings.spec.ts): Update test to interact with global variables and improve readability and maintainability of the code
|
finally! |
italojohnny
approved these changes
Sep 9, 2024
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* first attempt to edit variables on the data table * refactor: Rename AddNewVariableButton to GlobalVariableModal and update its usage The component AddNewVariableButton has been renamed to GlobalVariableModal to better reflect its purpose. The component is now used in multiple places, including the GlobalVariablesPage and InputGlobalComponent. This change improves code clarity and consistency. * fix: fix apply to fields on table edit option * refactor: Trim field names before checking for availability in GlobalVariableModal and GlobalVariablesPage Trim field names before checking for availability in GlobalVariableModal and GlobalVariablesPage to ensure consistent comparison and avoid any potential issues with leading or trailing spaces. * Refactor GlobalVariablesPage to remove unused cellRenderer in the "value" field * [autofix.ci] apply automated fixes * Add validation for 'value' field in VariableRead model and import CREDENTIAL_TYPE - Introduced a field validator for the 'value' field in the VariableRead model to handle cases where the variable type is CREDENTIAL_TYPE. - Added necessary import for CREDENTIAL_TYPE. - Removed an unnecessary blank line in the variable API. * Add constants for credential and generic types in variable service * Refactor import statements in `kubernetes.py` to improve module organization * Refactor imports in test_service.py for better organization * refactor: Update import statements in variable.py for better organization * Refactor import and reorder fields in VariableRead model - Changed import of `CREDENTIAL_TYPE` from `service` to `constants` module. - Reordered fields in `VariableRead` model to place `type` before `value`. * ✨ (userSettings.spec.ts): Add additional randomName variables for testing purposes 📝 (userSettings.spec.ts): Update test to interact with global variables and improve readability and maintainability of the code * test: fix test_create_variable --------- Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org> Co-authored-by: cristhianzl <cristhian.lousa@gmail.com> Co-authored-by: italojohnny <italojohnnydosanjos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can update Global Variables name, value and default fields on the global variables page
#3462