Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update flow name validation and label #3785

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes changes to improve the name validation and the invalid name list functionality. The commit "Changed text warning name invalid" updates the text warning for invalid names to include the message "Name invalid or already exists". The commit "Change invalidNameList to include components" modifies the invalid name list to include components as well. These changes aim to enhance the user experience and ensure accurate validation of names.

@lucaseduoli lucaseduoli self-assigned this Sep 12, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 12, 2024 15:20
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 12, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3785.dmtpw4p5recq1.amplifyapp.com

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
… purpose of the code block and improve code readability
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 12, 2024
@lucaseduoli lucaseduoli merged commit 128a0e9 into main Sep 12, 2024
28 checks passed
@lucaseduoli lucaseduoli deleted the fix/flow_name_invalid branch September 12, 2024 19:47
smatiolids pushed a commit to smatiolids/langflow-dev that referenced this pull request Sep 16, 2024
* Changed text warning name invalid

* Change invalidNameList to include components

* 📝 (generalBugs-shard-13.spec.ts): add missing comments to clarify the purpose of the code block and improve code readability

---------

Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Changed text warning name invalid

* Change invalidNameList to include components

* 📝 (generalBugs-shard-13.spec.ts): add missing comments to clarify the purpose of the code block and improve code readability

---------

Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants