Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds model selection to Azure OpenAI Embeddings component #3882

Conversation

philnash
Copy link
Contributor

Right now the Azure OpenAI Embeddings component doesn't allow you to pick the embedding model to use. Azure make the same models available as OpenAI (see Azure docs), so I used the constant that lists them to pull from.

Right now the Azure OpenAI Embeddings component doesn't allow you to pick the embedding model to use. The same models are available that OpenAI make available, so I used the constant that lists them to pull from.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Sep 23, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 23, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3882.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @philnash

Thanks for this.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@philnash
Copy link
Contributor Author

I noticed that two of the checks have failed. Is there something I need to do about that? Or, given many others have passed, are they just flaky tests?

@ogabrielluiz ogabrielluiz merged commit 7a01cf7 into langflow-ai:main Sep 26, 2024
35 of 36 checks passed
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…flow-ai#3882)

Right now the Azure OpenAI Embeddings component doesn't allow you to pick the embedding model to use. The same models are available that OpenAI make available, so I used the constant that lists them to pull from.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants