Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve file uploader size validation - custom hook #3952

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request will create a new custom hook to validate the file sizes besides validate on each component.

…lidate file size before upload to improve code readability and maintainability
… validation to use a custom hook for better code organization and readability
…m hook for file size validation instead of utility store

🔧 (FileInput/index.tsx): remove dependency on utility store for max file size upload and use a custom hook for file size validation instead
…izeValidator to validate file size before uploading it
@Cristhianzl Cristhianzl self-assigned this Sep 27, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Sep 27, 2024
@Cristhianzl Cristhianzl requested review from italojohnny and removed request for lucaseduoli and anovazzi1 September 27, 2024 17:49
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 27, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 27, 2024 17:51
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3952.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@Cristhianzl Cristhianzl merged commit 6db1525 into main Sep 27, 2024
35 of 37 checks passed
@Cristhianzl Cristhianzl deleted the cz/file-uploader-hook-validator branch September 27, 2024 18:01
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…i#3952)

* 📝 (inputFileComponent/index.tsx): add useFileSizeValidator hook to validate file size before upload to improve code readability and maintainability

* 📝 (chatInput/index.tsx): remove unused imports and refactor file size validation to use a custom hook for better code organization and readability

* 📝 (FileInput/index.tsx): refactor file input component to use a custom hook for file size validation instead of utility store
🔧 (FileInput/index.tsx): remove dependency on utility store for max file size upload and use a custom hook for file size validation instead

* ✨ (use-file-size-validator.tsx): introduce a new custom hook useFileSizeValidator to validate file size before uploading it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants