Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StoreMessage.py to prevent errors on Component #4162

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

Cristhianzl
Copy link
Member

📝 (StoreMessage.py): Update input types in StoreMessageComponent to include StrInput for sender, sender_name, and session_id to improve data handling and consistency.

…nclude StrInput for sender, sender_name, and session_id to improve data handling and consistency.
@Cristhianzl Cristhianzl self-assigned this Oct 15, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 15, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 15, 2024
@Cristhianzl Cristhianzl changed the title fix: rollback StoreMessage.py to prevent errors on Component fix: StoreMessage.py to prevent errors on Component Oct 15, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 15, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be MessageTextInput

…ut class from langflow.inputs.inputs module for sender, sender_name, and session_id inputs in StoreMessageComponent class. This change ensures consistency and improves code readability.
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) October 15, 2024 18:58
@Cristhianzl Cristhianzl merged commit f14ead9 into main Oct 16, 2024
27 checks passed
@Cristhianzl Cristhianzl deleted the cz/rollback-store-message branch October 16, 2024 01:38
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* 📝 (StoreMessage.py): Update input types in StoreMessageComponent to include StrInput for sender, sender_name, and session_id to improve data handling and consistency.

* 📝 (StoreMessage.py): Update imports to use the correct MessageTextInput class from langflow.inputs.inputs module for sender, sender_name, and session_id inputs in StoreMessageComponent class. This change ensures consistency and improves code readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants